Skip to content

fix: use buffer channel to resolve missing email notifications #3099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

LordofAvernus
Copy link
Collaborator

@LordofAvernus LordofAvernus commented Jul 25, 2025

User description

What

  • Emails failed to send after workflow finish

关联的 issue

#3097

描述你的变更

修复工单上线没有邮件通知

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 修改 workflowStatusChan 添加缓冲

  • 修复工单邮件通知问题

  • 确保状态同步正常传递


File Walkthrough

Relevant files
Bug fix
workflow_schedule.go
修改工作流状态通道缓冲方式                                                                                       

sqle/server/workflow_schedule.go

  • 将 workflowStatusChan 改为带缓冲通道
  • 确保状态信息正常同步传递
+1/-1     

**What**
- Emails failed to send after workflow finish
@actiontech-bot actiontech-bot requested a review from BugsGuru July 25, 2025 05:32
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@BugsGuru BugsGuru merged commit 0f0e56a into main Jul 25, 2025
4 checks passed
@BugsGuru BugsGuru deleted the fix-3097 branch July 25, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants