Skip to content

Update prettier feature #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Update prettier feature #1061

merged 2 commits into from
Jun 6, 2025

Conversation

Jimver
Copy link
Contributor

@Jimver Jimver commented Jun 4, 2025

The prettier feature doesn't seem to work, throwing an error that it cannot be resolved when trying to build the devcontainer. Let's update it to the one found on the https://containers.dev/features website (search for prettier)

[954 ms] Start: Run: docker -v
[996 ms] Start: Resolving Remote
[998 ms] Start: Run: git rev-parse --show-cdup
[1030 ms] Loading 32 extra certificates from C:\Users\Jim\AppData\Local\Temp\vsch\certificates-96df20d0e428f608528f9572f1743a3afbd1cfc6b075b47e07664a55d2a1a3be.pem.
[1081 ms] Start: Run: docker ps -q -a --filter label=devcontainer.local_folder=c:\Users\Jim\source\glob-test --filter label=devcontainer.config_file=c:\Users\Jim\source\glob-test\.devcontainer\devcontainer.json
[1130 ms] Start: Run: docker inspect --type image mcr.microsoft.com/devcontainers/typescript-node:20
[1212 ms] Resolving Feature dependencies for 'ghcr.io/devcontainers/features/github-cli:1'...
[1212 ms] * Processing feature: ghcr.io/devcontainers/features/github-cli:1
[1350 ms] Start: Run: docker-credential-desktop get
[1845 ms] * Processing feature: ghcr.io/devcontainers/features/common-utils
[2018 ms] * Processing feature: ghcr.io/devcontainers/features/git
[2323 ms] Resolving Feature dependencies for 'ghcr.io/devcontainers-contrib/features/prettier:1'...
[2323 ms] * Processing feature: ghcr.io/devcontainers-contrib/features/prettier:1
[2470 ms] Could not resolve Feature manifest for 'ghcr.io/devcontainers-contrib/features/prettier:1'.  If necessary, provide registry credentials with 'docker login <registry>'.
[2470 ms] Github feature.
[2470 ms] Could not resolve Feature 'ghcr.io/devcontainers-contrib/features/prettier:1'.  Ensure the Feature is published and accessible from your current environment.
[2471 ms] Error: ERR: Feature 'ghcr.io/devcontainers-contrib/features/prettier:1' could not be processed.  You may not have permission to access this Feature, or may not be logged in.  If the issue persists, report this to the Feature author.
[2471 ms]     at FX (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:287:9690)
[2471 ms]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2471 ms]     at async eC (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:287:12258)
[2472 ms]     at async vu (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:287:12484)
[2472 ms]     at async Tu (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:392:1818)
[2472 ms]     at async gC (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:395:2228)
[2472 ms]     at async Wu (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:395:282)
[2472 ms]     at async dw (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:467:1923)
[2472 ms]     at async Ix (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:467:608)
[2472 ms]     at async Y6 (c:\Users\Jim\.vscode\extensions\ms-vscode-remote.remote-containers-0.413.0\dist\spec-node\devContainersSpecCLI.js:484:3842)
[2479 ms] Exit code 1

@Jimver Jimver requested a review from a team as a code owner June 4, 2025 20:04
- The prettier feature doesn't seem to work, throwing an error that it
  cannot be resolved when trying to build the devcontainer.
- Let's update it to the one found on the
  https://containers.dev/features website (search for prettier to find
  the feature location).
@ncalteen ncalteen self-assigned this Jun 6, 2025
Copy link
Collaborator

@ncalteen ncalteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants