Skip to content

fix: Fail if none of the given packages can be installed #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Fail if none of the given packages can be installed #3825

wants to merge 2 commits into from

Conversation

nekketsuuu
Copy link

I found that apt_get_with_fallbacks in installdependencies.sh returns 0 even if it fails to install all of the given packages. This patch fixes it by returning non-zero value.

@Copilot Copilot AI review requested due to automatic review settings April 28, 2025 03:09
@nekketsuuu nekketsuuu requested a review from a team as a code owner April 28, 2025 03:09
Copilot
Copilot AI reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/Misc/layoutbin/installdependencies.sh: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nekketsuuu