Update dockerfile to ubuntu:24.04 #3771
Conversation
In addition to cleaning up the apt lists, remove downloaded packages This will reduce the size of the layers by a litte bit
Update from Jammy to Noble. Add the dotnet runtime dependencies to Dockerfile
|
Also, I don't know if your test suite will cover the Dockerfile, but I can confirm that I am using the above as a base for my self hosted runner. So its building and running with the github api. The only change I had to make to a downstream Dockerimage was to add "--break-system-packages" to the subsequent pip3 command in my local build image |
|
Thanks for this Joshua - hopefully they update it soon |
Update github and docker dependencies. Fill in missing linux dependency version ARGS
joshua-clayton
force-pushed
the
update-dockerfile
branch
from
7040625 to
659d62a
Compare
|
While waiting for review, I'm updating the dependencies to reflect releases since march. Once this is accepted, the internal github dependencies will be kept up to date by Github's own release process, but while I'm waiting for this to be merged, I need to keep my forked copy up to date. |
|
@TingluoHuang I'd love to get this upgrade merged. Any objection to moving to Ubuntu 24.04? |
| sudo \ | ||
| unzip \ | ||
| zlib1g \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Configure git-core/ppa based on guidance here: https://git-scm.com/download/linux | ||
| RUN add-apt-repository ppa:git-core/ppa \ |
There was a problem hiding this comment.
combine together with previous run not to make extra layer + i don't see any reasoning to add extra repo just to get upstream git version
The Dockerfile has gotten pretty stale, and as a base for build images,
leaves a lot of CVEs and vulnerabilities which are easily fixed by moving to a more recent base.
Update it to the most recent Ubuntu LTS.
I'm not sure if there is a more recent version of the dotnet image, but it seemed simpler to
me to follow the installation instructions for action-runner in the Dockerfile.
Lastly, I added apt-get upgrade to the beginning of each apt command,
which will keep the image up to date with the source image if it is rebuilt,
and apt-get clean to the end of each apt command, which will keep the resultant
layers smaller by removing apt download cache leftovers