Refactor Packer templates for Windows and Ubuntu images

[Alexey-Ayupov]

Description

This pull request introduces significant updates to the image build pipeline, including parameter adjustments, template refactoring, and improvements to support multiple operating systems. The key changes involve adding new parameters, refactoring image templates for Ubuntu, and introducing logic to dynamically handle image properties based on the operating system.

Parameter Updates:

• Added a new BuildTemplateName parameter to images.CI/linux-and-win/build-image.ps1 to specify the build template name dynamically.
• Replaced the pluginVersion parameter with UseAzureCliAuth (default: "false") and updated the PluginVersion default to "2.3.3".

Template Refactoring:

• Refactored Ubuntu image templates (build.ubuntu-22_04.pkr.hcl, build.ubuntu-24_04.pkr.hcl, build.ubuntu-minimal.pkr.hcl) by removing hardcoded variables and replacing them with shared local variables for better maintainability. [1] [2] [3]
• Renamed and updated image templates to align with the new naming convention and structure. [1] [2] [3]

Dynamic Image Handling:

• Introduced a switch statement in build-image.ps1 to determine the appropriate imageURN based on the BuildTemplateName. This adds support for new OS versions like Windows 2025 and Ubuntu 24.04.
• Added local variables in locals.ubuntu.pkr.hcl to dynamically set image properties (e.g., OS type, disk size) based on the image_sku.

Packer Build Improvements:

• Updated packer validate and packer build commands to use the BuildTemplateName dynamically for better flexibility.
• Added new variables to pass Azure image publisher, offer, and SKU details during the build process.

These changes enhance the flexibility and scalability of the image build pipeline while improving code maintainability and support for new operating systems.

Related issue:

Check list

• Related issue / work item is attached
• Tests are written (if applicable)
• Documentation is updated (if applicable)
• Changes are tested and related VM images are successfully generated

[maxim-lobanov]

Will it be better if we pass image_os to packer instead of image_sku? And we will choose image_sku here based on image_os. With this approach, we will be able to move hardcoded skus from build-image.ps1 to locals.ubuntu.pkr.hcl and locals.windows.pkr.hcl

[Alexey-Ayupov]

It makes sense, will update this part

[maxim-lobanov]

nit: what is the $buildName here? can we use full name?

[Alexey-Ayupov]

The $buildName here is a second part of build packer template (e.g. if we targeting windows-2025 image with build.windows-2025.pkr.hcl template, the build name will be windows-2025)
We can name our build templates whatever we want. What name do you want?

[maxim-lobanov]

This comment is relevant for full locals block or only first property?

[Alexey-Ayupov]

This is true for the entire block. I had to copy it from the ubuntu-minimal template to make the refactoring work. If we're not using the ubuntu-minimal image, maybe we should remove it?

[maxim-lobanov]

consider removing ubuntu-minimal template and this variable

[Alexey-Ayupov]

+1

[maxim-lobanov]

I think we should use different toolset for different images

[Alexey-Ayupov]

This local is also for ubuntu-minimal image. Let's delete the ubuntu-minimal image and related locals.

[maxim-lobanov]

Two suggestions:

• instead of using if condition a == b ? c : d == e ? f :g, consider using maps in HCL.
• consider using coalesce for os_disk_size_gb
  It should be something like this:

image_properties_map = {
  "2019-Datacenter" = {
    image_os = "win19"
    os_disk_size_gb = coalesce(var.os_disk_size_gb, 256)
  },
  "2022-Datacenter" = {
      image_os = "win22"Add commentMore actions
      os_disk_size_gb = coalesce(var.os_disk_size_gb, 256)
  }
}
image_properties = image_properties_map[var.image_sku]