enh: Enhance message saving functionality and /channels command by DonatienBaille · Pull Request #43 · actionbrk/abeille

DonatienBaille · 2025-04-14T23:21:50Z

Refactor ChannelsCommand to improve text channel handling and pagination.
Introduce saveMessagesForGuild function for better message saving logic.
Add support for thread creation and deletion events.
Implement getAllTextChannels utility for fetching viewable text channels.
Update localization files for new responses.

This PR also:

Optimize channel deletion with batch delete
Improve error management when syncing guild messages on start
Enhance message saving and daily counters with atomic transactions

Closes #29
Closes #40

- Refactor ChannelsCommand to improve text channel handling and pagination. - Introduce saveMessagesForGuild function for better message saving logic. - Add support for thread creation and deletion events. - Implement getAllTextChannels utility for fetching viewable text channels. - Update localization files for new responses.

Copilot

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (2)

src/locales/en-US.json: Language not supported
src/locales/fr.json: Language not supported

Comments suppressed due to low confidence (2)

src/commands/admin/savechannel.ts:37

Consider awaiting the saveMessagesForGuild call to properly handle errors and provide timely user feedback. If fire-and-forget is intentional, please document the rationale.

saveMessagesForGuild(interaction.guild!, undefined, interaction, channel.id);

src/commands/admin/save.ts:191

Ensure that using 'viewableChannels' (which may include non-text channels) to derive channel IDs for cleanup is the intended behavior, as it differs from the earlier use of the filtered text channels.

const channelsIds = viewableChannels.map((channel) => channel.id);

…uild function

…r handling and readability

…tion

…nsactions

Copilot

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (2)

src/locales/en-US.json: Language not supported
src/locales/fr.json: Language not supported

Comments suppressed due to low confidence (2)

src/database/bee-database.ts:16

Ensure that the immediate invocation of the transaction callback (using () after db.transaction) is fully supported by your database driver API and that error handling within the transaction is sufficient.

db.transaction(() => { ... })();

src/commands/admin/channels.ts:135

[nitpick] Consider adding a comment to explain the regex replacement for thread formatting to improve code clarity and maintainability.

.replace(/├ ([^\n]*)$/, "└ $1")

…tegrity and fixing a bug

Copilot

Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (2)

src/locales/en-US.json: Language not supported
src/locales/fr.json: Language not supported

…e accurate message counts

…eadability

Copilot

Copilot reviewed 16 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (3)

.dockerignore: Language not supported
src/locales/en-US.json: Language not supported
src/locales/fr.json: Language not supported

Comments suppressed due to low confidence (2)

src/database/bee-database.ts:16

Verify that the immediate invocation pattern (i.e. appending '()' after db.transaction) is supported by your DB library. If not, refactor to explicitly commit or rollback the transaction with proper error handling.

db.transaction(() => {

src/events/threads/thread-create.ts:8

[nitpick] Consider renaming the parameter 'newlyCreate' to 'isNewlyCreated' to enhance code readability and clarity.

async execute(thread: AnyThreadChannel, newlyCreate: boolean) {

Copilot

Pull Request Overview

This PR enhances Abeille’s message saving functionality and channel management by refactoring command logic, improving database transactions, and adding support for thread events. Key changes include:

Refactored ChannelsCommand to support pagination and detailed channel/thread statistics.
Updated message saving flows with atomic transactions and improved filtering.
Added new event handlers for thread creation and deletion, along with documentation improvements.

Reviewed Changes

Copilot reviewed 19 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/loaders.ts	Added informative logging for locale loading
src/events/threads/thread-delete.ts	Introduced thread deletion handling with message cleanup
src/events/threads/thread-create.ts	Added thread creation event with asynchronous join logic
src/events/messages/message-create.ts	Updated message saving logic using improved filtering
src/events/client-ready.ts	Refactored guild message sync using Promise.all
src/database/bee-database.ts	Wrapped inserts and updates in atomic transactions with counter updates
src/commands/admin/savechannel.ts	Simplified channel save command by delegating to saveMessagesForGuild
src/commands/admin/save.ts	Extended save functionality to filter messages by channel ID
src/commands/admin/channels.ts	Implemented pagination and enhanced grouping of channel statistics
src/commands/activity/*	Replaced deferred reply variable with direct await for clarity
docs/* and README.md	Updated documentation to reflect new features and guidelines
CONTRIBUTING.md	Added contributing guidelines and style conventions

Files not reviewed (4)

.dockerignore: Language not supported
.env.template: Language not supported
src/locales/en-US.json: Language not supported
src/locales/fr.json: Language not supported

Comments suppressed due to low confidence (1)

src/commands/admin/channels.ts:240

[nitpick] While updating button states for pagination, ensure that edge cases (such as dynamic changes to the number of pages) are handled to avoid potential UI inconsistencies.

row.components[0]!.setDisabled(currentPage === 0).setLabel("◀");

Copilot · 2025-04-15T23:14:52Z

+      // Atomic update with check to prevent negative counter
+      const updateStatement = db.query(`
+        UPDATE messageday
+        SET count = MAX(0, count ${isDelete ? "-" : "+"} 1)


[nitpick] The inline arithmetic operation in the SQL query may be misinterpreted due to tight formatting; consider adding explicit spacing or parentheses to improve clarity and maintainability.

Suggested change

SET count = MAX(0, count ${isDelete ? "-" : "+"} 1)

SET count = MAX(0, (count ${isDelete ? " - " : " + "} 1))

actionbrk · 2025-04-16T21:14:24Z

+  threadManager: ThreadManager,
+  textChannels: Collection<string, GuildBasedChannel & TextBasedChannel>
+): Promise<void> {
+  const activeChannelThreads = await threadManager.fetchActive(true);


I have a "Missing access" error when running fetchActive and fetchArchived for every text channels in my test server :(

I don't know why (yet), but it does stop the saving process. Could you add something to catch the error?

Copilot

Pull Request Overview

This PR enhances the message saving functionality and improves channel management commands. Key changes include:

Refactoring message saving logic (including handling threads) and optimizing database transactions.
Adding events for thread creation and deletion.
Improving the /channels command with pagination and enhanced channel statistics formatting.
Updating documentation to reflect new features, architecture, and security best practices.

Reviewed Changes

Copilot reviewed 19 out of 23 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/loaders.ts	Added logging for locale loading progress.
src/events/threads/thread-delete.ts	New event to handle thread deletion and cleanup messages.
src/events/threads/thread-create.ts	New event to handle thread creation and joining new threads.
src/events/messages/message-create.ts	Updated message filtering logic with improved filtering function.
src/events/client-ready.ts	Refactored guild message syncing logic using Promise.all.
src/database/bee-database.ts	Refactored message saving transactions and daily counter updates.
src/commands/admin/savechannel.ts	Simplified channel saving by calling saveMessagesForGuild.
src/commands/admin/save.ts	Improved message fetching and thread handling in save flow.
src/commands/admin/channels.ts	Enhanced channel statistics command with embed pagination.
src/commands/activity/*	Removed redundant reply deferral in activity commands.
docs/*, README.md, CONTRIBUTING.md	Updated and added documentation regarding architecture and security.

Files not reviewed (4)

.dockerignore: Language not supported
.env.template: Language not supported
src/locales/en-US.json: Language not supported
src/locales/fr.json: Language not supported

Comments suppressed due to low confidence (2)

src/events/threads/thread-create.ts:8

[nitpick] Consider renaming the 'newlyCreate' parameter to 'newlyCreated' for improved clarity and consistency.

async execute(thread: AnyThreadChannel, newlyCreate: boolean) {

src/database/bee-database.ts:42

The immediately invoked transaction function pattern may be unconventional. Verify that the db.transaction API supports this usage pattern without introducing side effects.

})();

DonatienBaille added the enhancement New feature or request label Apr 14, 2025

DonatienBaille self-assigned this Apr 14, 2025

DonatienBaille linked an issue Apr 14, 2025 that may be closed by this pull request

Support threads #29

Closed

DonatienBaille requested review from actionbrk and Copilot April 14, 2025 23:21

Copilot AI reviewed Apr 14, 2025

View reviewed changes

DonatienBaille added 6 commits April 15, 2025 01:42

fix: Optimize channel deletion process by batching SQL statements

39162b0

fix: Ensure saveMessagesForGuild is awaited in savechannel command

e4838d0

fix: Correctly map channel IDs from text channels in saveMessagesForG…

bcaa246

…uild function

fix: Refactor syncMessagesOfGuilds to use async/await for better erro…

3bffe54

…r handling and readability

fix: Correct typo in README regarding environment variables configura…

da8b6bb

…tion

fix: Enhance message saving and daily counter updates with atomic tra…

e9a8d78

…nsactions

DonatienBaille requested a review from Copilot April 14, 2025 23:53

Copilot AI reviewed Apr 14, 2025

View reviewed changes

fix: Wrap daily counts calculation in a transaction to ensure data in…

fc2f3e6

…tegrity and fixing a bug

DonatienBaille requested a review from Copilot April 15, 2025 00:17

Copilot AI reviewed Apr 15, 2025

View reviewed changes

Comment thread src/commands/admin/channels.ts

DonatienBaille added 5 commits April 15, 2025 23:09

fix: Improve channel categorization logic to handle threads and ensur…

5e79f30

…e accurate message counts

fix: Simplify deferReply handling in activity commands for improved r…

b9f7ec1

…eadability

fix: Add db directory to .dockerignore for improved build efficiency

a63b888

fix: Add logging for locale loading process to improve traceability

ca76003

fix: Option and choice initialization in command translations

170b9e8

DonatienBaille requested a review from Copilot April 15, 2025 22:04

Copilot AI reviewed Apr 15, 2025

View reviewed changes

feat: Improve project documentation

2858ff3

DonatienBaille requested a review from Copilot April 15, 2025 23:14

Copilot AI reviewed Apr 15, 2025

View reviewed changes

actionbrk reviewed Apr 16, 2025

View reviewed changes

fix: Add permission check for managing private threads

87b4e21

DonatienBaille requested review from actionbrk and Copilot April 20, 2025 18:38

Copilot AI reviewed Apr 20, 2025

View reviewed changes

Merge branch 'master' into 29-support-threads

0e8d348

actionbrk merged commit 578ae8b into master Apr 22, 2025

DonatienBaille deleted the 29-support-threads branch April 23, 2025 19:52

Navigation Menu

Repository navigation

enh: Enhance message saving functionality and /channels command - #43

enh: Enhance message saving functionality and /channels command#43
actionbrk merged 16 commits into
masterfrom
29-support-threads

DonatienBaille commented Apr 14, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2025

Uh oh!

actionbrk Apr 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	SET count = MAX(0, count ${isDelete ? "-" : "+"} 1)
	SET count = MAX(0, (count ${isDelete ? " - " : " + "} 1))

Conversation

DonatienBaille commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

actionbrk Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DonatienBaille commented Apr 14, 2025 •

edited

Loading