Resolve language-rule issues #2365
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| This `span` element has a `lang` [attribute value][] of `fr` (French), which matches one of its [most common languages][most common language]. The most common languages are both English and French because all the words belong to both languages. | ||
|
|
||
| **Note**: The `body` element in HTML are optional and will be added by the browser. |
There was a problem hiding this comment.
Given that it seems there are only 2 examples in that rule without a body element (Passed Examples 4 and 5), I'd say it is simpler to add the body element to both rather than adding this note.
| --- | ||
|
|
||
| The _most common language of an element_ is determined by counting the number of _words_ in the [text inheriting its programmatic language][] from this element that are part of any of the languages in the [language subtag registry][]. The same word can be part of multiple languages. In case of ties, the element has several most common languages. If there are no words in the [text inheriting its programmatic language][] from the element, then it has no most common language. | ||
| The _most common language of an element_ is determined by counting the number of _words_ in the [text inheriting its programmatic language][] from this element that are part of any of the languages in the [language subtag registry][]. The same word can be part of multiple languages. In case of a tie, the first of the tied languages used in the text is the most common language. If there are no words in the [text inheriting its programmatic language][] from the element or the tie cannot be resolved, then it has no most common language. |
There was a problem hiding this comment.
This removes the possibility of having several most common languages (this is OK), but then the description of Passed Examples 4/5 of "HTML element language subtag matches language" (and maybe some other) need to be updated accordingly. They still read
This
spanelement has alang[attribute value][] offr(French), which matches one of its [most common languages][most common language]. The most common languages are both English and French because all the words belong to both languages.
stating that there are 2 "most common languages".
This PR resolves a number of smaller language rule issues.
Need for Call for Review: 1 week
How to Review And Approve