Skip to content

Changed navbar link process (it was weird for hack school page) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanwang0114 merged 2 commits into from
Oct 3, 2025
Merged

Changed navbar link process (it was weird for hack school page) #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf255b0
change navbar link process
Ayush1124 Oct 3, 2025
4a1256b
Update index.tsx
Ayush1124 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/components/navbar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import Link from 'next/link';
import React, { useState } from 'react';
import { useRouter, usePathname } from 'next/navigation';
import styles from './style.module.css';
import Logo from '../../../public/Logo';

Expand All @@ -16,6 +17,8 @@ const NAV_LINKS = [

const Navbar: React.FC = () => {
const [isMenuOpen, setIsMenuOpen] = useState(false);
const router = useRouter();
const pathname = usePathname();

// Inject smooth scroll CSS once
React.useEffect(() => {
Expand All @@ -31,15 +34,19 @@ const Navbar: React.FC = () => {
const handleNavClick = (e: React.MouseEvent<HTMLElement>, href: string) => {
if (href.startsWith('/#')) {
e.preventDefault();
const id = href.split('#')[1];
const el = document.getElementById(id);
if (el) {
el.scrollIntoView({ behavior: 'smooth' });
}
// Optionally close menu on mobile
setIsMenuOpen(false);
// Update URL hash without page reload
window.history.pushState(null, '', href);
if (pathname === '/') {
// Already on home, scroll smoothly
const id = href.split('#')[1];
const el = document.getElementById(id);
if (el) {
el.scrollIntoView({ behavior: 'smooth' });
}
window.history.pushState(null, '', href);
} else {
// Not on home, navigate to home with hash
router.push(href);
}
}
};

Expand Down
2 changes: 1 addition & 1 deletion src/homepage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const HomePage: NextPage<{ past_events: EventsArray; future_events: EventsArray
<section id="team">
<Team />
</section>
<section id="contact">{/* Add your Contact component or content here */}</section>
<section id="contact">{}</section>
</main>
);
};
Expand Down