-
Notifications
You must be signed in to change notification settings - Fork 742
Wardrobe - Compats: CUP Units #10905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
OverlordZorn
wants to merge
314
commits into
acemod:master
Choose a base branch
from
OverlordZorn:ace-wardrobe-compat-cup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Wardrobe - Compats: CUP Units #10905
OverlordZorn
wants to merge
314
commits into
acemod:master
from
OverlordZorn:ace-wardrobe-compat-cup
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: johnb432 <[email protected]>
…nto ace-wardrobe
Co-authored-by: johnb432 <[email protected]>
…nto ace-wardrobe
Due to how previously all wardrobe info was stored inside the items config, before it got moved into configFile >> ACE_Wardrobe, alot of configs were not needed anymore and could be replaced directly with the classname.
upon further thoughts i cannot think of a way where it would make sense to use the wardrobe framework to change the wearable for an ai unit. simply changing them via code directly is nearly always simpler and faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ToDo
Requirements
Co Contributor
@Andx667