Skip to content

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Mar 15, 2025

When merged this pull request will:

  • Code cleanup & optimisation.
  • Fix and improve ownership transfer of explosives when a unit receives a detonator from another. If a unit has multiple detonators to give, it will only pass explosive ownership when the last one is passed to the receiving unit.
  • Reverted invalid IED codes immediately stopping call, which was unintentionally introduced in Explosives - Improve Support for custom IED ringtones #10731.
  • Eliminate race condition for getting IED cellphone code.
  • Cache detonators.
  • Check variable types in public functions.
  • Remove ace_explosives_fnc_detonateExplosiveAll, as it's just a forEach loop.
  • Remove ace_explosives_fnc_dialingPhone, as it's only used in 1 instance, is relatively short and isn't API.
  • Improve documentation.
  • Address ACE3 Feature Requests #3594 (comment) by adding ace_explosives_defuseStart and adding missing documentation for ace_explosives_defuse and ace_explosives_explodeOnDefuse.
  • Fully test all features.
    • Test cellphones.
    • Test ownership transfer when moving detonators from one container to the next.
    • Test planting explosives.
    • Test defusing.
    • Test detonators (timer, pressure, remote).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Mar 15, 2025
@PabstMirror
Copy link
Contributor

merged fix from #10958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants