-
-
Notifications
You must be signed in to change notification settings - Fork 101
feat(ui): restructure split panel layout and add AI chat panel #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): restructure split panel layout and add AI chat panel #396
Conversation
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]> Co-authored-by: nitro56565 <[email protected]> Co-authored-by: Matt Roberts <[email protected]> Signed-off-by: nitro56565 <[email protected]>
* tailwind integration added with preflight as false Signed-off-by: nitro56565 <[email protected]> * ai assistant foundation Signed-off-by: Akshat Batra <[email protected]> --------- Signed-off-by: nitro56565 <[email protected]> Signed-off-by: Akshat Batra <[email protected]> Co-authored-by: nitro56565 <[email protected]> Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
d4e8f57 to
7571b26
Compare
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
sanketshevkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality for the explore button is broken. Can you please fix that?
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: nitro56565 <[email protected]>
akshatbatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a few adjustments to fix the explanation popup appearance.
Signed-off-by: nitro56565 <[email protected]>
|
Can't we just stack up the panels one another a particular dimension/viewport is hit? The Preview panel and the AI assistant panel should go under the editor section. |
|
Scroll on preview window is not working. @nitro56565 can you please check that as well? |
We can do this @sanketshevkar but the UI experience wont be that good as this layout is in such a way that if we try to stack it up then we have to first go through individual editors scroll view then preview window scroll and then comes the AI section which will be very annoying as per UI. let me know your thoughts on this. |
Signed-off-by: nitro56565 <[email protected]>
This issue has been resolved @sanketshevkar |
Signed-off-by: nitro56565 <[email protected]>
When we say we don't support mobile experience, I don't think its good idea to ship a complete broken experience. We don't expect them to use, so we don't build features with mobile optimisations, but surely shipping broken experience as you can see in the preview window is a bad idea. We should at least have some message for them saying they should open up this app in desktop view to have a better experience, probably as a popup. I'll merge this for now but please follow up on this focus as this as your next PR. |
Closes #380
Changes
PanelGroupFlags
Live Preview
Related Issues
Author Checklist
--signoffoption of git commit.gsoc/feature-branchfromfork:branchname