Fixes #35: Upgrade eslint to 9.x.x and fix the line ending issue for win vs unix… #41
Conversation
…ccordproject#35 Signed-off-by: Chibuezem Marvinrose <[email protected]>
Signed-off-by: Chibuezem Marvinrose <[email protected]>
|
I’ve submitted a PR that successfully resolves this issue. |
sanketshevkar
left a comment
sanketshevkar
left a comment
There was a problem hiding this comment.
Thanks for taking out time and making this contribution. This seems like a good start.
There are quite a few things that seems off and extra from what is required. I've flagged those. Can you please look into those?
If you're using any kind of AI tool, I'd like to suggest to please cross check its generated code and verify if the changes are needed are not. AI tools do tend to hallucinate and might generate extra code that makes maintainers' job to review the code difficult and needs extra effort.
| @@ -0,0 +1,16 @@ | |||
| import globals from 'globals'; | |||
There was a problem hiding this comment.
Why does this require two config files? One with JS and other with mjs?
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; |
There was a problem hiding this comment.
We don't want to remove these.
| * @param {*} priorModels - known models | ||
| * @param {string} namespace - the namespace | ||
| * @return {*} the model | ||
| * @returns {*} the model |
| "eslint": "9.21.0", | ||
| "eslint-plugin-jsdoc": "50.6.3", | ||
| "eslint-plugin-react": "7.37.4", | ||
| "globals": "16.0.0", |
There was a problem hiding this comment.
Why are globals and eslint-plugin-react packages required?
| "semver": "7.6.3", | ||
| "typescript": "5.7.2" | ||
| "typescript": "5.7.2", | ||
| "typescript-eslint": "8.26.0" |
There was a problem hiding this comment.
Why is typescript-eslint required?
| * @param {Array<{ source: string, destination: string }>} files - List of files to copy. | ||
| * @param {string} destDir - The destination directory. | ||
| * @returns {Promise<void>} - A promise that resolves when the files are copied. | ||
| */ |
There was a problem hiding this comment.
We don't need to document this using jsdoc. We don't expose this method as APIs.
|
Can you please comment on the issue so that we can assign you? |
|
Thank you so much for the review and feedback. |
|
@Marvinrose you'll have to comment on the issue for me to assign you. |
|
@sanketshevkar I just did please |
2 participants
Changes Made:
Testing:
npx eslint . --fixsuccessfully.My Environment: