fix: safely load assemblies in ConcertoTypeDictionary #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update all projects' target framework in `.NET8.0` (from `standard2.0`) - Update all projects' C# version to 12 (from 10) - Updated NuGet packages - Fixes for compilation: 1. `ConcertoConverter.deserializeWithGenericType` chose the wrong overloaded method. Added expected parameters to choose the correct method. 2. Added `Decorator.cs` to declare the existence of `AccordProject.Concerto.Decorator` namespace, because the code generation script added `using AccordProject.Concerto.Decorator` for some reason and the compilation failed. Signed-off-by: Yuval Bavli <[email protected]>
Change assembly.GetTypes() to a more lenient approach "GetLoadableTypes()" where ReflectionTypeLoadException is being ignored, and we load only the types that we are able to load. The reason for this is that there may be some dlls that will fail to load which will fail the entire flow. For example the following error (which happened): ReflectionTypeLoadException : Unable to load one or more of the requested types.\nCould not load type 'SqlGuidCaster' from assembly 'System.Data.SqlClient, Version=4.6.1.6, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' because it contains an object field at offset 0 that is incorrectly aligned or overlapped by a non-object field." Signed-off-by: Yuval Bavli <[email protected]>
jamieshorten
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: safely load assemblies in
ConcertoTypeDictionaryChanges
Change assembly.GetTypes() to a more lenient approach "GetLoadableTypes()" where
ReflectionTypeLoadExceptionis being ignored, and we load only the types that we are able to load.The reason for this is that there may be some dlls that will fail to load, which will fail the entire flow.
For example, the following error (which happened):
This way, a single faulty/incompatible assembly won't fail the entire flow
Author Checklist
--signoffoption of git commit.mainfromybavli-dsc:main