Use runtime config for assets #305
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR:
The main use case for providing runtime config is to override
local_directory
option when using Elixir releases:The above is a method to use patched version of
@absinthe/socket
dependency which fixes the missing headers bug (see absinthe-graphql/absinthe-socket#67)As far as I know this cannot be achieved using compile-time configuration, because
Application.app_dir(:my_app)
is not available at that time. Besides, compile-time configuration didn't work anyway - it was inducing a compilation error.assets
option from plug'sinit/1
type specification, because it was not used there.