Change cancellation coloring to *exist* in opt, just be a no-op. - #1135
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_959632628
branch
3 times, most recently
from
August 6, 2026 00:19
910c17d to
54ed11a
Compare
This makes coloring checks (and machinery that interacts with coloring) easier to implement because it can be implemented unambiguously, just becoming a no-op in debug mode. PiperOrigin-RevId: 959962853
copybara-service
Bot
force-pushed
the
test_959632628
branch
from
August 6, 2026 00:37
54ed11a to
30ccbc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change cancellation coloring to exist in opt, just be a no-op.
This makes coloring checks (and machinery that interacts with coloring) easier to implement because it can be implemented unambiguously, just becoming a no-op in debug mode.