Zalo Chat and Users Parser#1511
Merged
Merged
Conversation
Contributor
Author
|
Thanks to @BrunoFischerGermany for the test data sets! |
Collaborator
|
2 small comments
|
Contributor
Author
|
You're right. It is indeed a phone number. I didn't notice the switch to "context." It's definitely easier to read. |
Collaborator
|
The context parameter also makes the modules more resilient to core code updates since changing the preamble of the processor function requires updates to every module. We can update context with new features now and not trigger a massive module update. |
Contributor
Author
|
I had changed it. It still works with my test data. So it should be fine, right? |
Collaborator
|
yes. take another look through and it looks good to me so merged it in base on you saying your tests still work. thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a parser for the app Zalo (most commonly used in Vietnam or by people with ties to Vietnam).
parses:
Some newer versions of the app use JPEG XL. To view them, you'll need a modern browser (currently mostly still in beta) or the latest version of LAVA.