Merge branch dev with rel-10.5#25633
Merged
Merged
Conversation
Angular - Fixing the loading state management problem for manage profile
Merge branch rel-10.5 with rel-10.4
voloagent
approved these changes
Jun 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This auto-generated merge PR brings dev changes into rel-10.5, mainly updating Angular UI behavior around loading indicators and the Manage Profile page state handling.
Changes:
- Refactored
abpLoadingdirective cleanup logic into a dedicatedclearLoading()method. - Updated Manage Profile component to use Angular signals (
toSignal,signal) and an explicitprofileLoadingflag instead ofAsyncPipe. - Adjusted Manage Profile template to consume signals and show the loading overlay based on
profileLoading().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| npm/ng-packs/packages/theme-shared/src/lib/directives/loading.directive.ts | Refactors loading cleanup, adds clearLoading(), and changes timer/load handling. |
| npm/ng-packs/packages/account/src/lib/components/manage-profile/manage-profile.component.ts | Moves profile state consumption to signals and introduces profileLoading toggled via finalize(). |
| npm/ng-packs/packages/account/src/lib/components/manage-profile/manage-profile.component.html | Switches template from AsyncPipe to signal reads and uses profileLoading() for [abpLoading]. |
Comment on lines
61
to
+64
| .subscribe(() => { | ||
| if (!this.loading()) { | ||
| return; | ||
| } |
Comment on lines
+88
to
+91
| if (this.rootNode?.parentElement) { | ||
| this.renderer.removeChild(this.rootNode.parentElement, this.rootNode); | ||
| this.rootNode = null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generated automatically to merge dev with rel-10.5. Please review the changed files before merging to prevent any errors that may occur.