Merge branch rel-10.5 with rel-10.4#25632
Merged
Merged
Conversation
Angular - Fixing the loading state management problem for manage profile
voloagent
approved these changes
Jun 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This automated merge PR aligns rel-10.4 with updates from rel-10.5, mainly around Angular UI loading behavior and the account “Manage Profile” screen’s state handling.
Changes:
- Refactored
abpLoadingdirective cleanup logic into a sharedclearLoading()helper and adjusted delayed rendering behavior. - Updated Manage Profile component to use Angular signals (
toSignal,signal) instead ofAsyncPipefor profile state + loading state. - Adjusted Manage Profile template bindings to use the new signal-based state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| npm/ng-packs/packages/theme-shared/src/lib/directives/loading.directive.ts | Refactors loading cleanup; introduces clearLoading() and changes timer callback behavior. |
| npm/ng-packs/packages/account/src/lib/components/manage-profile/manage-profile.component.ts | Switches profile state consumption to toSignal and introduces a profileLoading signal for abpLoading. |
| npm/ng-packs/packages/account/src/lib/components/manage-profile/manage-profile.component.html | Updates template to use signal invocations (profile(), profileLoading()) and new conditional blocks. |
Comment on lines
61
to
+65
| .subscribe(() => { | ||
| if (!this.loading()) { | ||
| return; | ||
| } | ||
|
|
Comment on lines
+88
to
+91
| if (this.rootNode?.parentElement) { | ||
| this.renderer.removeChild(this.rootNode.parentElement, this.rootNode); | ||
| this.rootNode = null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generated automatically to merge rel-10.5 with rel-10.4. Please review the changed files before merging to prevent any errors that may occur.