Skip to content

Fix NullReferenceException in ClientProxyUrlBuilder #23462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Fix NullReferenceException in ClientProxyUrlBuilder #23462

merged 1 commit into from
Aug 7, 2025

Conversation

gdlcf88
Copy link
Contributor

@gdlcf88 gdlcf88 commented Aug 6, 2025

Resolves #23461.

@maliming
Copy link
Member

maliming commented Aug 7, 2025

hi @gdlcf88

Can you test this case?

https://localhost:44000/api/my-endpoint?pages[0]=&pages[1]=

What is the value of public List<string?> Pages { get; set; }?

Emply or two emply items?

Thanks.

@maliming maliming self-requested a review August 7, 2025 02:53
@gdlcf88
Copy link
Contributor Author

gdlcf88 commented Aug 7, 2025

I happened to test this case.

The debugger said that there are two items in the List<string> parameterValue and both of them are null.

image image

@maliming maliming merged commit e38a69e into abpframework:dev Aug 7, 2025
2 checks passed
@maliming maliming added this to the 10.0-preview milestone Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliming maliming maliming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0-preview
Development

Successfully merging this pull request may close these issues.

Null query params cause Remote Service Error
2 participants
@gdlcf88 @maliming