-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Support S3 Compatible Blob Storage Providers #22962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
enisn
wants to merge
6
commits into
dev
Choose a base branch
from
aws-service-url
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
24c2715
Add ServiceURL configuration for S3-compatible APIs
enisn 0f46fb4
Add unit tests for AwsBlobProviderConfiguration and DefaultAmazonS3Cl…
enisn 6acf535
Enhance AWS Blob Storing Documentation for S3-Compatible Services
enisn 898a313
Add CloudFlare R2 example documentation
enisn 4f2a141
Make region optional for some S3 compatible APIs
enisn c40f453
Configure `ResponseChecksumValidation` hwne third party S3 providers …
enisn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
....Abp.BlobStoring.Aws.Tests/Volo/Abp/BlobStoring/Aws/AwsBlobProviderConfiguration_Tests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
using Shouldly; | ||
using Xunit; | ||
|
||
namespace Volo.Abp.BlobStoring.Aws; | ||
|
||
public class AwsBlobProviderConfiguration_Tests : AbpBlobStoringAwsTestCommonBase | ||
{ | ||
[Fact] | ||
public void Should_Set_And_Get_ServiceURL() | ||
{ | ||
// Arrange | ||
var containerConfiguration = new BlobContainerConfiguration(); | ||
var awsConfiguration = new AwsBlobProviderConfiguration(containerConfiguration); | ||
const string serviceUrl = "https://minio.example.com:9000"; | ||
|
||
// Act | ||
awsConfiguration.ServiceURL = serviceUrl; | ||
|
||
// Assert | ||
awsConfiguration.ServiceURL.ShouldBe(serviceUrl); | ||
} | ||
|
||
[Fact] | ||
public void Should_Return_Null_When_ServiceURL_Not_Set() | ||
{ | ||
// Arrange | ||
var containerConfiguration = new BlobContainerConfiguration(); | ||
var awsConfiguration = new AwsBlobProviderConfiguration(containerConfiguration); | ||
|
||
// Act & Assert | ||
awsConfiguration.ServiceURL.ShouldBeNull(); | ||
} | ||
|
||
[Fact] | ||
public void Should_Configure_ServiceURL_Using_UseAws_Extension() | ||
{ | ||
// Arrange | ||
var containerConfiguration = new BlobContainerConfiguration(); | ||
const string serviceUrl = "https://spaces.digitalocean.com"; | ||
|
||
// Act | ||
containerConfiguration.UseAws(config => | ||
{ | ||
config.ServiceURL = serviceUrl; | ||
config.Region = "us-east-1"; | ||
}); | ||
|
||
// Assert | ||
var awsConfig = containerConfiguration.GetAwsConfiguration(); | ||
awsConfig.ServiceURL.ShouldBe(serviceUrl); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the
Async
method will be better.