feat: esm and cjs build - #58
Open
jaensen wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces dual ESM and CommonJS builds across several packages while updating package versions to a preview release. Key changes include:
- Updating Rollup configurations for separate ESM and CJS outputs with new file naming conventions.
- Removing the JSON plugin and outDir settings from TypeScript and tsconfig configurations.
- Updating package.json files to reflect new build output paths and version bumps.
Reviewed Changes
Copilot reviewed 20 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/data/rollup.config.js | Introduces ESM/CJS build outputs with new file naming |
| packages/data/package.json | Updates build entry points and version |
| packages/adapter/* | Updates Rollup and tsconfig for dual build support |
| packages/adapter-safe/* | Similar ESM/CJS changes and removal of nodePolyfills |
| packages/adapter-safe-app/* | Adjustments for dual outputs and removal of outDir in tsconfig |
| packages/adapter-ethers/* | Adjustments for dual outputs with updated package dependencies |
| packages/abi-v2/* | Similar dual build changes and tsconfig updates |
| packages/abi-v1/* | Similar dual build changes and tsconfig updates |
| package.json | Root package version bump and name update |
Comments suppressed due to low confidence (2)
packages/adapter-safe/rollup.config.js:1
- The removal of the nodePolyfills plugin could lead to issues if parts of the package rely on Node-specific polyfills. Ensure that this change is intentional and that the build remains compatible across target environments.
import typescript from '@rollup/plugin-typescript';
packages/adapter/tsconfig.json:4
- Removing the outDir setting from the tsconfig files may affect build outputs. It would be helpful to add a comment or documentation explaining how and where the output directory is now configured to avoid confusion.
"baseUrl": "./",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.