Update stats to reflect sent messages includes recevied #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy previously made it sounds like only messages sent were counted, which could be confusing for users who think this is messages sent to Ably, or sent from Ably, but not both.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
m-hulbert
reviewed
Jul 25, 2025
Comment on lines
+378
to
+381
| | messages.all.all.count | Total number of messages that were successfully received or sent by Ably, summed over all message types and transports. | | ||
| | messages.all.all.billableCount | Total number of billable messages that were successfully received or sent by Ably, summed over all message types and transports. | | ||
| | messages.all.all.data | Total data in messages successfully received or sent by Ably, summed over all message types and transports. | | ||
| | messages.all.all.uncompressedData | Total data in messages successfully received or sent by Ably, excluding savings provided delta compression. | |
There was a problem hiding this comment.
Should this be 'received and sent' rather than 'or' in that case?
|
Could we consider making these sort of wording improvements in the authoritative schema at https://github.com/ably/ably-common/blob/main/json-schemas/src/app-stats.json , and having a docs repo script that populates this table from that we can run every so often? So we're not making different wording improvements to the two independently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy previously made it sounds like only messages sent were counted, which could be confusing for users who think this is messages sent to Ably, or sent from Ably, but not both.
See somewhat related Slack message which surfaced this.