Skip to content

support multiline while quote is unclosed #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support multiline while quote is unclosed #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94642d4
support multiline while quote is unclosed
doggeddog Oct 31, 2019
7b120bd
support multiline while quote is unclosed
doggeddog Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ishell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func (s *Shell) readMultiLinesFunc(f func(string) bool) (string, error) {
var line string
line, err = s.readLine()
fmt.Fprint(&lines, line)
if !f(line) || err != nil {
if (!f(line) || err != nil) && isQuoteClosed(lines.String()) {
break
}
fmt.Fprintln(&lines)
Expand Down Expand Up @@ -718,3 +718,11 @@ func getPosition() (int, int, error) {

return col, row, nil
}

func isQuoteClosed(lines string) bool {
_, err := shlex.Split(lines)
if err != nil && err.Error() == "EOF found when expecting closing quote." {
return false
}
return true
}