Align packageManager to npm + fix stale lockfile name (closes #15) - #22
Merged
Conversation
The repo declared packageManager: pnpm@9.12.0 but has only an npm lockfile (no pnpm-lock.yaml) and an npm-only .npmrc (legacy-peer-deps), so a contributor honoring the pnpm pin would get a divergent, unlocked tree. Align the field to npm@11.6.1 (the lockfile + .npmrc reality) and sync the lockfile's stale pre-rebrand name (agentsim-workspace -> volo-workspace). Minimal + safe: no lockfile regeneration, so all cross-platform @img/sharp binaries (incl. the Linux ones CI/Vercel need) are preserved; JSON validated. Enforcing 'npm ci' in CI to keep the lockfile from being rewritten is a follow-up. Closes #15.
🛫 Volo reliability — ❌ NO-SHIPReplayed 7 adversarial scenarios against the agent (threshold ≥ 0.90).
Cost — replayed deterministically at $0 (no live API calls). baseline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
The repo declared
"packageManager": "pnpm@9.12.0"but has only an npm lockfile (nopnpm-lock.yaml) and an npm-only.npmrc(legacy-peer-deps=true), so a contributor honoring the pnpm pin would runpnpm installand get a divergent, unlocked tree.Change (minimal + safe)
packageManager:pnpm@9.12.0→npm@11.6.1(the lockfile +.npmrcreality).package-lock.jsonname: stale pre-rebrandagentsim-workspace→volo-workspace.No lockfile regeneration — I edited only the name string, so all cross-platform
@img/sharpbinaries (incl. the 15 Linux ones CI/Vercel image optimization needs) are preserved; both files validated as JSON. 3 lines changed.Follow-up (not in this PR)
Enforce
npm ci(nevernpm install) in CI/Docker so the lockfile is never rewritten and platform optionals can't be pruned by a Windows/mac dev's install. Left out to keep this change minimal and low-risk.