feat(setup): report the resolved Flock config in setup --check - #31
Closed
abeljim8am wants to merge 1 commit into
Closed
feat(setup): report the resolved Flock config in setup --check#31abeljim8am wants to merge 1 commit into
setup --check#31abeljim8am wants to merge 1 commit into
Conversation
`setup --check` listed the directories Flock searches but not what it resolved,
so the questions that actually go wrong needed a live session and a dump-layout to
answer: which layout won, whether the flock { } section reached the plugins, and
whether bare flock will open the selector. It now reports:
[STARTUP LAYOUT]: built-in "flock"
[SELECTOR ON STARTUP]: yes
[PROJECT ROOT DIRS]: "~/src", "~/work"
[PROJECT INDIVIDUAL DIRS]: none
[REMOTE PROVIDERS]: devcontainers, ssh
[FLOCK PLUGIN ALIASES]: flock-selector, flock-sidebar
[STARTUP LAYOUT] distinguishes a built-in from one of the user's own layout files
by path, so "why am I not getting my default.kdl" is answerable without starting
a session — the exact thing that made verifying the layout-fallback work awkward.
Configuration that silently does nothing is the recurring failure mode in this
area, so the report is deliberately loud rather than terse in three cases: no
project folders configured (with the consequence and the fix), the selector opted
out of startup (naming `flock pick` as the way back), and a missing flock plugin
alias, which makes the whole flock { } section inert for that plugin.
That last case cannot be reached by editing config.kdl — alias merging can
override an entry but never remove one — but it is reachable through the public
plugin_aliases_with_flock_defaults, so it is reported rather than left to be
discovered, and unit-tested rather than left as dead code.
Completes the out-of-the-box plan: the README rewrite and the documented
flock { } block in default.kdl landed in the earlier phases, verified here rather
than assumed.
abeljim8am
force-pushed
the
feat/setup-check-flock-config
branch
from
August 4, 2026 15:34
b15b4fa to
51580c0
Compare
Collaborator
|
Superseded by mega PR #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
setup --checklisted the directories Flock searches but not what it resolved. So the questions that actually go wrong needed a live session and adump-layoutto answer — which is precisely what made verifying #27 and #29 by hand awkward:flock { }section reach the plugins?flockopen the selector?It now reports all three:
[STARTUP LAYOUT]distinguishes a built-in from one of your own layout files by path, so "why am I not getting mydefault.kdl" is answerable without starting a session.Deliberately loud, not terse
Configuration that silently does nothing is the recurring failure mode in this area, so three cases get an explanation rather than a value:
Likewise the selector being opted out (naming
flock pickas the way back), and a missingflockplugin alias — which would make the wholeflock { }section inert for that plugin.On that last case: it cannot be reached by editing
config.kdl, because alias merging can override an entry but never remove one. I kept it anyway becauseplugin_aliases_with_flock_defaultsis public API and aConfigin that state silently ignores the section — but I unit-tested it rather than leaving unreachable, untested code in place.The other two Phase 4 items
Both had already landed in the earlier phases, and I verified that rather than assuming it:
flock-selector location=/codespaces_enabled "true");setup --dump-configdoes emit the documentedflock { }block.The README now also points at
setup --check, and the plan doc records the two as done.Verification
cargo xtask test— 2376 passing, 0 failures.cargo xtask format --checkclean. No snapshot churn and no plugin-asset changes (nothing in a plugin changed).falseis not listed as enabled, and that the nag disappears once folders are set), the selector opt-out namingflock pick, and the missing-alias warning.selector_on_startup false+ its ownlayouts/default.kdl, confirming[STARTUP LAYOUT]reports that file by path.🤖 Generated with Claude Code