chore: bump node-pre-gyp/node-gyp to move off vulnerable tar@6#64
Open
eguchi-lab wants to merge 1 commit intoabandonware:masterfrom
Open
chore: bump node-pre-gyp/node-gyp to move off vulnerable tar@6#64eguchi-lab wants to merge 1 commit intoabandonware:masterfrom
eguchi-lab wants to merge 1 commit intoabandonware:masterfrom
Conversation
Author
|
Thanks for the review. Yes, I tested this change in my fork (Node v22.17.0 / npm 11.7.0). Commands run:
Results:
I have not yet run native build/install verification on Linux/Windows in this branch. I can add that if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@mapbox/node-pre-gypfrom^1.0.11to^2.0.3node-gypfrom^10.0.1to^11.5.0package-lock.jsonWhy
Current lockfile resolves
tar@6.2.1through install-time dependencies:@mapbox/node-pre-gyp@1.x -> tar@6.xnode-gyp@10.x -> tar@6.xThis blocks remediation for recent
taradvisories (including hardlink/symlink escape class issues).After this change, lockfile resolution is on
tar@7.5.9.Verification
npm install --package-lock-only --ignore-scripts --forcenpm audit --omit=dev --omit=optional=>found 0 vulnerabilitiesCompatibility / risk
@mapbox/node-pre-gyp@2.xrequires Node>=18, so this may affect older Node install scenarios.If this repo must preserve older Node install support, we should treat this as a breaking change and release accordingly.