Merged
Conversation
Open
atrovato
force-pushed
the
bitcloud-pr121_binding-options
branch
from
ee79378 to
5a99808
Compare
rzr
reviewed
Dec 23, 2020
rzr
reviewed
Dec 23, 2020
rzr
reviewed
Dec 23, 2020
rzr
reviewed
Dec 23, 2020
rzr
reviewed
Dec 23, 2020
rzr
requested changes
Dec 23, 2020
Merged
atrovato
force-pushed
the
bitcloud-pr121_binding-options
branch
from
5a99808 to
d88b9b4
Compare
atrovato
force-pushed
the
bitcloud-pr121_binding-options
branch
3 times, most recently
from
1a79ec2 to
7b26d99
Compare
Merged
atrovato
force-pushed
the
bitcloud-pr121_binding-options
branch
5 times, most recently
from
e8cf1f6 to
4953229
Compare
rzr
approved these changes
Feb 15, 2021
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
double check welcome from other @abandonware/reviewers
|
please rebase |
atrovato
force-pushed
the
bitcloud-pr121_binding-options
branch
from
4953229 to
fd0cfdb
Compare
Author
|
Done. |
rzr
reviewed
Feb 23, 2021
README.md
Outdated
| If you are using multiple HCI devices in one setup you can run two instances of noble with different binding configurations by initializing them seperatly in code: | ||
|
|
||
| ``` | ||
| const HCIBindings = require('noble/lib/hci-socket/bindings'); |
There was a problem hiding this comment.
shouldnt it align to require('@abandonware/noble'); ?
or otherwise please add:
npm install bleno@npm:@abandonware/bleno
and remote @abanonware prefix elsewhere
rzr
reviewed
Feb 23, 2021
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
may lint changes be isolated in separate pr ?
Author
|
Do you mean #182 ? |
atrovato
force-pushed
the
bitcloud-pr121_binding-options
branch
from
fd0cfdb to
311044b
Compare
atrovato
force-pushed
the
bitcloud-pr121_binding-options
branch
from
311044b to
2ce4a16
Compare
rzr
reviewed
Feb 23, 2021
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
LGTM what about other @abandonware/reviewers ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #121