chore: tracking txs usd amounts to amplitude #2564
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mgrabina
force-pushed
the
feat/tracking-usd-amounts
branch
from
293a472 to
bbb8816
Compare
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
@grothem are we missing any places top of mind for calculating all the amount flows |
mgrabina
force-pushed
the
feat/tracking-usd-amounts
branch
from
bbb8816 to
bee5e1b
Compare
rebased |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
@mgrabina are we able to handle the corner case of repay max? its USD value is -1 |
@mgrabina repay max
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
good catch! fixed now |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| @@ -197,8 +200,11 @@ export const RepayActions = ({ | |||
| action, | |||
| txState: 'success', | |||
| asset: poolAddress, | |||
| amount: amountToRepay, | |||
| amount: amountToRepay === '-1' ? maxAmountToRepay : amountToRepay, | |||
There was a problem hiding this comment.
@mgrabina should this change?
There was a problem hiding this comment.
i think we just care about the amountUsd for that value
There was a problem hiding this comment.
we currently have the same issue in amount sending -1
There was a problem hiding this comment.
but is it changing anything in the actual transaction or is it just information sent to amplitude
There was a problem hiding this comment.
Nope transaction is sent just above
(whatsmore addTransaction only executed if tx was successful)
and addTransaction just 'saves' the tx in the state, which are used only in TransactionEventHandler just for tracking
|
@mgrabina repaying wSTETH left negative balance 
|
did u pull the latest? 
|
e.g.
