Skip to content

using family api for token prices in swaps when possible #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

mgrabina
Copy link
Contributor

@mgrabina mgrabina commented Jun 11, 2025

Still using cow for custom tokens + testnets, otherwise -> family.

Closes AAVE-449

Copy link

linear bot commented Jun 11, 2025

Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 5:16pm

@mgrabina mgrabina force-pushed the feat/using-family-prices-service branch from cefc63e to a672277 Compare June 11, 2025 15:12
@mgrabina mgrabina force-pushed the feat/using-family-prices-service branch from a672277 to 532de76 Compare June 11, 2025 15:17
@mgrabina mgrabina force-pushed the feat/using-family-prices-service branch from 532de76 to 3c80e52 Compare June 11, 2025 15:24
@mgrabina mgrabina marked this pull request as ready for review June 11, 2025 15:31
@mgrabina mgrabina changed the title using family api for fetching usd prices in swaps using family api for token prices in swaps Jun 11, 2025
@mgrabina mgrabina requested a review from absis June 11, 2025 15:32
Copy link

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +355 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/safety-module 38.21 KB (🟡 +201 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +374 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/safety-module 38.21 KB (🟡 +201 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Copy link

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +354 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/safety-module 38.21 KB (🟡 +201 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@mgrabina mgrabina requested a review from absis June 11, 2025 20:20
grothem
grothem previously approved these changes Jun 12, 2025
@mgrabina mgrabina changed the title using family api for token prices in swaps [waiting chains support] using family api for token prices in swaps Jun 25, 2025
@mgrabina mgrabina force-pushed the feat/using-family-prices-service branch from f175b48 to ba3b189 Compare July 1, 2025 17:00
Copy link

github-actions bot commented Jul 1, 2025

Copy link

github-actions bot commented Jul 1, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +24 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.51 KB (🟡 +100 B) 1.44 MB
/bridge 33.39 KB (🟡 +607 B) 1.43 MB
/markets 31.29 KB (🟡 +100 B) 1.42 MB
/safety-module 38.3 KB (🟡 +100 B) 1.43 MB
/v3-migration 34.17 KB (🟡 +100 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@mgrabina mgrabina dismissed stale reviews from JoaquinBattilana and grothem via ab5272b July 1, 2025 17:09
@mgrabina mgrabina force-pushed the feat/using-family-prices-service branch from ba3b189 to ab5272b Compare July 1, 2025 17:09
@mgrabina mgrabina changed the title [waiting chains support] using family api for token prices in swaps using family api for token prices in swaps when possible Jul 1, 2025
Copy link

github-actions bot commented Jul 1, 2025

Copy link

github-actions bot commented Jul 1, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +23 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.51 KB (🟡 +100 B) 1.44 MB
/bridge 33.39 KB (🟡 +607 B) 1.43 MB
/markets 31.29 KB (🟡 +100 B) 1.42 MB
/safety-module 38.3 KB (🟡 +100 B) 1.43 MB
/v3-migration 34.17 KB (🟡 +100 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@mgrabina mgrabina merged commit 2d0ee5e into main Jul 3, 2025
19 of 22 checks passed
@mgrabina mgrabina deleted the feat/using-family-prices-service branch July 3, 2025 19:38
mgrabina added a commit that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants