Fix target path for header file generation#67
Merged
Conversation
When we integrated the code gen call in our dev_scripts, we accidentally introduced a bug where both .cpp and .hpp files are generated into the src folder. This breaks build as .hpp files are shipped from the include directory, instead. Instead, with this commit we generate into a temporary directory and copy the generated artefacts into the correct directories.
The codegen script ignored the target directory for the code generation, generating into `src/` by default. Hence, we fix it to use the `--target` CLI argument, instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we integrated the code gen call in our dev_scripts, we
accidentally introduced a bug where both .cpp and .hpp files are
generated into the src folder. This breaks build as .hpp files are
shipped from the include directory, instead.
Instead, with this commit we generate into a temporary directory and
copy the generated artifacts into the correct directories.
Fixes #66.