Move build dependencies into dev_scripts#61
Merged
Conversation
empwilli
force-pushed
the
empwilli/first_codegen_steps
branch
6 times, most recently
from
7bbb44d to
ad2cff6
Compare
The dev_scripts formerly relied on `setup.py`. As of today, the recommended standard is `pyproject.toml`. We, therefore, migrate to this new standard.
icontract is not used in the project, as such we drop this dependency.
In the past the generation of the code in this repo happened as part of the release process in `aas-core-codegen`. Updating aas-core3.0-cpp then merely was a step of copying test data over. However, this causes deep coupling between these two repos. To uncouple the repos, we move the snippets to this repo and call `aas-core-codegen` from the dev_scripts, instead.
empwilli
force-pushed
the
empwilli/first_codegen_steps
branch
2 times, most recently
from
057d306 to
6dd1b36
Compare
Currently, there are some circular dependencies in code and test generation. As an intermediate step to resolve these dependencies, we drop the test generation from the dev_scripts.
In future versions we want to cut the fixed dependencies to the meta model. In a first step we add a downloader script which allows users to manually update the meta model used for generation.
In order to uncouple meta model, code, and test generation, we now opt for explicitly moving the current meta model for which the SDK is generated to the dev_scripts. This breaks the dependency and even allows us to perform changes to the meta, if they have not been merged to aas_core_meta.
empwilli
force-pushed
the
empwilli/first_codegen_steps
branch
from
6dd1b36 to
240415e
Compare
empwilli
changed the title
empwilli
changed the title
dev_scripts
empwilli
changed the title
dev_scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release process relies on a number of separate dependencies:
aas-core-testgen,aas-core-codgen, andaas-core-meta. However, as theseprojects also rely on one-another, the result is a complicated mess of
interdependent software. To cut these dependencies at the resp. target SDK side,
we move the respective dependencies (snippets, meta-model.py) into the
dev_scripts, as well as the generated test data. Furthermore, we now generatethe SDK code as part of the
dev_scripts.