Add Xquik OpenAPI example and harden JSON decoding - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc5a421514
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Verified the 3 Codex review findings against the current PR head. Validation: YAML parse, |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
6df32bd to
9b3703f
Compare
|
Repair verification is complete at signed head I preserved the validated source tree exactly while adding verified SSH signatures to all 4 commits. All 3 earlier Codex findings remain fixed and their threads are resolved. The later review-quota bot message is informational and requests no code change. The full Go suite passes, Go formatting and the diff are clean, the Xquik OpenAPI fixture parses and imports into 4 tools, and trailing JSON values are covered by regression tests. No Xquik action remains. This is ready to merge. |
|
Published the current-contract repair at signed and GitHub-verified head The Xquik fixture now requires the forwarded Validation passed with GitHub Actions shows |
Summary
q, write-account fields, andIdempotency-KeyheadersIndependent Repository Fix
The gateway limited reads to 1 MiB without verifying whether more bytes remained. A valid JSON value followed by data beyond that boundary could therefore bypass the trailing-value check. The decoder now reads at most 1 MiB plus one byte and rejects oversized bodies from known-length and streaming requests.
Validation
make checkmake examplego test -race ./...go run golang.org/x/vuln/cmd/govulncheck@latest ./...- no vulnerabilitiesIdempotency-Keyheaders and account fieldsqand exposes current pagination fieldsgit diff --checkThe repository's Windows CI workflow awaits maintainer approval for this external contribution.
Xquik is an independent third-party service. Not affiliated with X Corp. "Twitter" and "X" are trademarks of X Corp.