Skip to content

Adding an option to turn off the default error screen on android #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding an option to turn off the default error screen on android #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions android/src/main/java/com/masteratul/exceptionhandler/ReactNativeExceptionHandlerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ public String getName() {
public void setHandlerforNativeException(
final boolean executeOriginalUncaughtExceptionHandler,
final boolean forceToQuit,
Callback customHandler) {
final boolean disableNativeErrorScreen,
Callback customHandler
) {

callbackHolder = customHandler;
originalHandler = Thread.getDefaultUncaughtExceptionHandler();
Expand All @@ -47,18 +49,20 @@ public void uncaughtException(Thread thread, Throwable throwable) {
String stackTraceString = Log.getStackTraceString(throwable);
callbackHolder.invoke(stackTraceString);

if (nativeExceptionHandler != null) {
nativeExceptionHandler.handleNativeException(thread, throwable, originalHandler);
} else {
activity = getCurrentActivity();
if (nativeExceptionHandler != null) {
nativeExceptionHandler.handleNativeException(thread, throwable, originalHandler);
} else {
if (!disableNativeErrorScreen) {
activity = getCurrentActivity();

Intent i = new Intent();
i.setClass(activity, errorIntentTargetClass);
i.putExtra("stack_trace_string",stackTraceString);
i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
Intent i = new Intent();
i.setClass(activity, errorIntentTargetClass);
i.putExtra("stack_trace_string", stackTraceString);
i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

activity.startActivity(i);
activity.finish();
activity.startActivity(i);
activity.finish();
}

if (executeOriginalUncaughtExceptionHandler && originalHandler != null) {
originalHandler.uncaughtException(thread, throwable);
Expand Down
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ declare const setNativeExceptionHandler: (
handler: NativeExceptionHandler,
forceAppQuit?: boolean, // Android only
executeDefaultHandler?: boolean,
disableNativeErrorScreen?: boolean // Android only
) => void;
9 changes: 7 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const setJSExceptionHandler = (customHandler = noop, allowedInDevMode = f

export const getJSExceptionHandler = () => global.ErrorUtils.getGlobalHandler();

export const setNativeExceptionHandler = (customErrorHandler = noop, forceApplicationToQuit = true, executeDefaultHandler = false) => {
export const setNativeExceptionHandler = (customErrorHandler = noop, forceApplicationToQuit = true, executeDefaultHandler = false, disableNativeErrorScreen = false) => {
if (typeof customErrorHandler !== "function" || typeof forceApplicationToQuit !== "boolean") {
console.log("setNativeExceptionHandler is called with wrong argument types.. first argument should be callback function and second argument is optional should be a boolean");
console.log("Not setting the native handler .. please fix setNativeExceptionHandler call");
Expand All @@ -34,7 +34,12 @@ export const setNativeExceptionHandler = (customErrorHandler = noop, forceApplic
if (Platform.OS === "ios") {
ReactNativeExceptionHandler.setHandlerforNativeException(executeDefaultHandler, customErrorHandler);
} else {
ReactNativeExceptionHandler.setHandlerforNativeException(executeDefaultHandler, forceApplicationToQuit, customErrorHandler);
ReactNativeExceptionHandler.setHandlerforNativeException(
executeDefaultHandler,
forceApplicationToQuit,
disableNativeErrorScreen,
customErrorHandler
);
}
};

Expand Down