chore: remove committed Obsidian vault and gitignore it - #192
Merged
jmesnil merged 1 commit intoJun 23, 2026
Merged
Conversation
The PRD/ directory tracked Obsidian editor state: PRD/.obsidian/ and the nested default vault PRD/a2a-tck prd/ (only .obsidian/ plus the default Welcome.md). Remove both and add .obsidian/ to .gitignore. Also resolve pre-existing merge-conflict markers left in .gitignore: keep .serena/ and .bob/, and ignore .claude/settings.local.json rather than the whole .claude/ directory, which would have untracked the committed .claude/skills entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up the .gitignore file by resolving merge conflict markers, removing obsolete local tool directories, and adding .obsidian/ to the ignore list. Additionally, it deletes several Obsidian configuration files (such as workspace, plugin, and graph settings) along with the default Welcome.md note. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
|
@millsmillsymills thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191
The
PRD/directory tracks Obsidian editor state that should not be version-controlled:PRD/.obsidian/(4 files)PRD/a2a-tck prd/— a nested default Obsidian vault containing only.obsidian/and the defaultWelcome.mdBoth are removed.
PRD/PRD.mdand the.mmddiagrams underPRD/are real content and are kept..obsidian/is added to.gitignore.While editing
.gitignoreI also resolved pre-existing merge-conflict markers (lines 203–210 onmain): kept.serena/and.bob/, and ignore.claude/settings.local.jsonrather than the whole.claude/directory — ignoring all of.claude/would be inconsistent with the tracked.claude/skillsentry.🤖 Generated with Claude Code