Skip to content

fix: pin starlette dependency to >=1.1.0 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmesnil merged 1 commit into from
May 27, 2026
Merged

fix: pin starlette dependency to >=1.1.0 #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codegen/a2a-python/pyproject.toml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ requires-python = ">=3.11"
dependencies = [
"a2a-sdk[http-server,grpc,sqlite]>={{ a2a_python_sdk_version }}",
"packaging",
"starlette",
"starlette>=1.1.0",

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Starlette does not have a 1.1.0 release on PyPI; its versioning is currently in the 0.x.y range (e.g., 0.45.x). Pinning to >=1.1.0 will cause dependency resolution to fail. If the intention was to pin to a recent version, use a valid 0.x.y version such as >=0.40.0.

    "starlette>=0.40.0",

@jmesnil jmesnil May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist. You're wrong: https://pypi.org/project/starlette/1.1.0.

Next time you review dependencies, please check pypi.org to ensure you have the latest information available.

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right, and I apologize for the error. My information regarding Starlette's versioning was outdated. Thank you for the correction and for pointing me to the current PyPI release.

"uvicorn",
]

Expand Down
2 changes: 1 addition & 1 deletion sut/a2a-python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ requires-python = ">=3.11"
dependencies = [
"a2a-sdk[http-server,grpc,sqlite]>=0.3.0",
"packaging",
"starlette",
"starlette>=1.1.0",
"uvicorn",
]

Expand Down
Loading