fix(a2a-grpc): preserve precise A2A error codes - #114
Merged
Conversation
Encode A2A error reasons as google.rpc.ErrorInfo details and recover trusted protocol reasons on the client. Keep the existing gRPC-code fallback for missing or invalid details. Fixes: a2aproject#103 Signed-off-by: King Star <mcxin.y@gmail.com>
msardara
requested changes
Jul 27, 2026
Forward ErrorInfo metadata and BadRequest field violations when converting A2A errors to gRPC status details. Cover every InvalidArgument protocol reason. Refs: a2aproject#103 Signed-off-by: King Star <mcxin.y@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
msardara
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gRPC boundary currently maps errors using only
tonic::Code. Six distinctA2A errors share
FAILED_PRECONDITION, so clients decode all of them asTaskNotCancelable. The server conversion also omits thegoogle.rpc.ErrorInfodetail that other SDKs need to recover the precise A2Areason.
Changes
ErrorInfowith the existing A2A reason anda2a-protocol.orgdomain from the server conversion.ErrorInfodetails and fieldviolations from existing
BadRequestdetails when constructing the gRPCstatus.
malformed, unknown, or foreign-domain details.
FAILED_PRECONDITIONmappings in both directions, including anindependently constructed peer status, and cover all four
INVALID_ARGUMENTreasons plus structured detail propagation.This uses
tonic-types, the official rich error model companion for theworkspace's existing Tonic 0.14 dependency.
Compatibility
The gRPC status codes and messages are unchanged. Existing peers without rich
details continue to use the previous fallback behavior. Malformed detail
entries are ignored rather than changing status conversion.
Verification
Fixes #103