Skip to content

ci: Switch Type checker to use ty from astral#1044

Merged
holtskinner merged 8 commits into
mainfrom
type-checking-ty
May 5, 2026
Merged

ci: Switch Type checker to use ty from astral#1044
holtskinner merged 8 commits into
mainfrom
type-checking-ty

Conversation

@holtskinner

Copy link
Copy Markdown
Member

- https://docs.astral.sh/ty/
- Replacement for mypy/pyright with faster performance
@holtskinner
holtskinner requested a review from a team as a code owner May 4, 2026 16:15
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

🧪 Code Coverage (vs main)

⬇️ Download Full Report

No coverage changes.

Generated by coverage-comment.yml

@holtskinner
holtskinner enabled auto-merge (squash) May 4, 2026 16:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's type-checking infrastructure from mypy and pyright to ty. The changes include updates to documentation, CI scripts, and dependency configurations, alongside a codebase-wide transition to ty-specific type-ignore comments. The review feedback focuses on further refining the code by removing a redundant type cast and cleaning up legacy type-ignore comments that were left in place during the migration.

Comment thread src/a2a/compat/v0_3/request_handler.py Outdated
Comment thread src/a2a/server/tasks/database_push_notification_config_store.py Outdated
Comment thread src/a2a/server/tasks/database_push_notification_config_store.py Outdated
holtskinner and others added 4 commits May 4, 2026 11:23
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner

Copy link
Copy Markdown
Member Author

@gemini-code-assist review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the project's type checking from mypy and pyright to ty. The changes involve updating the development dependencies, configuration files, documentation, and linting scripts. Additionally, type ignore comments across the source code have been migrated to the ty syntax. Review feedback recommends using explicit string conversions for gRPC metadata values instead of type ignores to ensure better type safety and compatibility.

Comment thread src/a2a/client/transports/grpc.py Outdated
Comment thread src/a2a/compat/v0_3/grpc_transport.py Outdated

@ishymko ishymko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@holtskinner
holtskinner merged commit 6b3b0d8 into main May 5, 2026
38 checks passed
@holtskinner
holtskinner deleted the type-checking-ty branch May 5, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants