-
Notifications
You must be signed in to change notification settings - Fork 153
fix: support authentication field in push notification config #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Soolan
wants to merge
6
commits into
a2aproject:main
Choose a base branch
from
Soolan:fix/push-notification-auth-239
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a439ac1
fix: support authentication field in push notification config (closes…
Soolan e8cb94f
style: fix lint errors
Soolan 2bf6afd
fix: prioritize Bearer over Basic auth scheme
Soolan b1f4881
style: fix lint errors in test assertion
Soolan 0a914eb
Merge branch 'main' into fix/push-notification-auth-239
Soolan d1991a6
Merge branch 'main' into fix/push-notification-auth-239
Soolan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation for handling authentication schemes has a flaw. If both
BearerandBasicschemes are present in theschemesarray, theAuthorizationheader will always be set toBasicbecause its check comes afterBearer, overwriting any previously set value. This behavior is non-obvious and likely not what's intended, as the order in theschemesarray is ignored.To make the behavior explicit and prefer one scheme over the other (e.g.,
Beareris generally preferred overBasic), you should use anif-else ifstructure. This ensures only one authentication header is set, with a clear precedence.