forked from SCOREC/core
-
Notifications
You must be signed in to change notification settings - Fork 0
Cmake cgns reader #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cwsmith
wants to merge
685
commits into
a-jp:cgns_reader
Choose a base branch
from
SCOREC:cmake_cgns_reader
base: cgns_reader
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see issue #341
When all the options are set to false for Pre, Mid, and Post balance, we check the imbalance and if it is bigger than in->maximumImbalance, then we choose the best option based on the following criteria a) if compiled with zoltan and #peers < 16K, use graph Zoltan b) if compiled with zoltan and #peers > 16K, use RIB Zoltan c) if compiled without zoltan, use parma
Using the size field information this logic figures out the required number of adapt iterations. If the number is larger than 10 we cap it to 10 and show a warning message to the user.
using target_compile_definitions
adds comment explaining the reason for having a condition on #parts when calling Zoltan Co-authored-by: Cameron Smith <[email protected]>
Options for mesh adapt
This way users cannot modify the input options. There is a new API ma::makeAdvanced that can be called on a const Input* to remove the constant-ness so (advanced) users can modify adapt options if they choose to do so.
the period is a literal not a wildcard
EN_getMatchingEnts takes two args
Takes care of clean up of sizefield and solutiontransfer objects at the end of adapt instead of inside d-tor of ma::Input.
… pass. Note the bigger changes were in getting the bump version of MGEN to write in the new (modelDim)*1M+dmg_model_dim approach. Some retooling was necessary since the box model has 0 values for tags of all 4 dimensions so error flags had to move to -1.
not sure why this was commented out
github ci builds were failing on this
fixes ci release build error
matchedNodeElementReader and serial mesh support for > 2B entities
Conflicts: CMakeLists.txt apf/apfConstruct.cc apf/apfConvert.h mds/apfMDS.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some cmake tweaks, namely the use of
bob_public_dep
.