ImageClip: copy base image. Improves performance in some cases. #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That's interesting, I will have to give it a deep dive to understand what is happening deep down before I can validate though |
OsaAjani
added
the
performance
Collaborator
|
Hi, could you provide some example code + media that illustrate the performances gap ? I would like to try and reproduce and see how pr #2490 influence this. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with performance in #2395 test to some extent.
If you check the
ndarray.flagsof certain frames, you see thatOWNDATAandC_CONTIGUOUSare sometimes false, which I think is slowing down something in PIL a lot. The copy is improving performance on the #2395 test by about 3x for me, on OS X ARM.