Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions docs/architecture/task-lifecycle-model.md

Large diffs are not rendered by default.

481 changes: 481 additions & 0 deletions scripts/check-task-store-concurrency.ts

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/__tests__/delegation-concurrent.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ vi.mock("fs", () => ({
}))

vi.mock("../utils/safeWriteJson", () => ({
lockJsonFile: vi.fn().mockResolvedValue(async () => {}),
safeWriteJson: vi.fn().mockResolvedValue(undefined),
}))

Expand Down
9 changes: 8 additions & 1 deletion src/__tests__/helpers/provider-stub.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,22 @@ type ProviderStubFields = {
delegationTransitionLocks?: Map<string, Promise<void>>
cancelledDelegationChildIds?: Set<string>
log?: ReturnType<typeof vi.fn>
taskHistoryStore?: { get: (id: string) => unknown }
taskHistoryStore?: {
get: (id: string) => unknown
withTaskFileLock?: <T>(id: string, callback: () => Promise<T>) => Promise<T>
}
taskRegistry?: TaskRegistry
clineStack?: Task[]
tasks?: Task[]
runDelegationTransition?: unknown
runLockedDelegationTransition?: unknown
removeClineFromStack?: unknown
evictCurrentTask?: unknown
}

type PrivateProviderMethods = {
runDelegationTransition: (this: unknown, ...args: unknown[]) => unknown
runLockedDelegationTransition: (this: unknown, ...args: unknown[]) => unknown
removeClineFromStack: (this: unknown, ...args: unknown[]) => unknown
evictCurrentTask: (this: unknown, ...args: unknown[]) => unknown
}
Expand All @@ -38,6 +43,7 @@ export function makeProviderStub<T extends object>(stub: T): ClineProvider {
s.cancelledDelegationChildIds ??= new Set()
s.log ??= vi.fn()
s.taskHistoryStore ??= { get: () => undefined }
s.taskHistoryStore.withTaskFileLock ??= async (_id, callback) => callback()

// Convert legacy clineStack array into a TaskRegistry
if (!s.taskRegistry) {
Expand All @@ -49,6 +55,7 @@ export function makeProviderStub<T extends object>(stub: T): ClineProvider {
delete s.clineStack

s.runDelegationTransition ??= proto.runDelegationTransition.bind(s)
s.runLockedDelegationTransition ??= proto.runLockedDelegationTransition.bind(s)
s.removeClineFromStack ??= proto.removeClineFromStack.bind(s)
s.evictCurrentTask ??= proto.evictCurrentTask.bind(s)
return s as unknown as ClineProvider
Expand Down
Loading
Loading