Skip to content

Conversation

@srivastava-ami
Copy link
Contributor

Apology for the long list of files in this checkin.
The base for this branch is bugfix/ZCS-6172.

thefoolwhocodes and others added 19 commits August 29, 2018 17:29
…efault LMDB max keysize * Add minor patch for issue fixed in upcoming 2.4.47 release
Copy link
Contributor

@thefoolwhocodes thefoolwhocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do following:

  • Remove the commits that existing on the develop.
  • Replay your changes on develop.

I can see many commits in the PR that has nothing to do with current work.

@thefoolwhocodes
Copy link
Contributor

One more request here, adding more description in PR request can be handy.

Problem: Provide ubuntu18 build to test
Approach and Fix:

  • ABC
  • CDE

Testing done:

  • XXX

@thefoolwhocodes
Copy link
Contributor

Files
thirdparty/nginx/zimbra-nginx/debian/changelog
thirdparty/nginx/zimbra-nginx/rpm/SPECS/nginx.spec

Are trying to override latest vals with stale information.
Technically your work will be increased merging these files out.
You can remove these commits too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants