Skip to content

Conversation

@wdomburg
Copy link

@wdomburg wdomburg commented May 9, 2018

Add the txid120 module to allow the generation of unique transaction identifiers to inbound requests.

@CLAassistant
Copy link

CLAassistant commented May 9, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@fatkudu fatkudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cd $(psrctmp)/$(pname)-$(pvers)-zimbra/modules && \
git clone https://github.com/synacor/nginx-module-txid120 >/dev/null 2>&1 && \
cd nginx-module-txid120 && \
rm -rf .git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a git archive might be useful here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we want to make sure we control exactly which version we are pulling in and have tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants