Skip to content

Replace insecure Pickle deserialization in cookie handling with safe JSON serialization to prevent remote code execution. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace insecure Pickle deserialization in cookie handling with safe JSON serialization to prevent remote code execution. #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bb7996
fix: replace insecure pickle deserialization with safe JSON handling
Jul 7, 2025
8fce109
docs: add comments to enhance code readability and context
Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions owasp-top10-2021-apps/a8/amarelo-designs/app/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@

from flask import Flask, request, make_response, render_template, redirect, flash
import uuid
import pickle
import json
import base64
app = Flask(__name__)


# Home sweet home: render the landing page
@app.route("/")
def ola():
return render_template('index.html')

# Admin login flow: only for the big boss
@app.route("/admin", methods=['GET','POST'])
def login():
if request.method == 'POST':
Expand All @@ -20,8 +22,9 @@ def login():
if username == "admin" and password == "admin":
token = str(uuid.uuid4().hex)
cookie = { "username":username, "admin":True, "sessionId":token }
pickle_resultado = pickle.dumps(cookie)
encodedSessionCookie = base64.b64encode(pickle_resultado)
# Rolling with JSON serialization + base64 for that secret sauce
json_bytes = json.dumps(cookie).encode('utf-8')
encodedSessionCookie = base64.b64encode(json_bytes)
resp = make_response(redirect("/user"))
resp.set_cookie("sessionId", encodedSessionCookie)
return resp
Expand All @@ -37,12 +40,17 @@ def userInfo():
cookie = request.cookies.get("sessionId")
if cookie == None:
return "Não Autorizado!"
cookie = pickle.loads(base64.b64decode(cookie))
# Decode the good vibes from our secure cookie
decoded = base64.b64decode(cookie)
# Unwrap JSON to get the session details
cookie = json.loads(decoded.decode('utf-8'))

# Show user dashboard, enjoy the ride!
return render_template('user.html')




if __name__ == '__main__':
# All aboard the server express!
app.run(debug=True,host='0.0.0.0')