Upgrade to 31.0.0 ; PRO-1257#5
Open
Sybrand wants to merge 5 commits into
Open
Conversation
public boolean hasCustomDimensions()
{
return !(dimensions == null || dimensions.isEmpty());
}
changed to:
public boolean hasFixedDimensions()
{
return dimensions != null && !dimensions.isEmpty() && !useSchemaDiscovery && !includeAllDimensions;
}
Rename DimensionsSpec#hasCustomDimensions to hasFixedDimensions and change the meaning subtly: it now
returns true if the DimensionsSpec represents an unchanging list of dimensions, or false if there is
some discovery happening. This is what call sites had expected anyway.
Sybrand
commented
Dec 13, 2024
| // existing specified dimensions? | ||
| Preconditions.checkArgument( | ||
| parseSpec.getDimensionsSpec().hasCustomDimensions(), | ||
| parseSpec.getDimensionsSpec().hasFixedDimensions(), |
Contributor
Author
There was a problem hiding this comment.
public boolean hasCustomDimensions()
{
return !(dimensions == null || dimensions.isEmpty());
}
changed to:
public boolean hasFixedDimensions()
{
return dimensions != null && !dimensions.isEmpty() && !useSchemaDiscovery && !includeAllDimensions;
}
"Rename DimensionsSpec#hasCustomDimensions to hasFixedDimensions and change the meaning subtly: it now
returns true if the DimensionsSpec represents an unchanging list of dimensions, or false if there is
some discovery happening. This is what call sites had expected anyway."
Sybrand
marked this pull request as ready for review
December 13, 2024 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrade extension to be compatible with druid 31.0.0
Change in dimensions spec going to 31:
changed to:
"Rename DimensionsSpec#hasCustomDimensions to hasFixedDimensions and change the meaning subtly: it now
returns true if the DimensionsSpec represents an unchanging list of dimensions, or false if there is
some discovery happening. This is what call sites had expected anyway."
Test
Imported zen data - compared total rows - it matches 29.0.0 and 29.0.1