fix(export): resolve wikilink images during PDF exports - #715
Open
Abhiraj1401 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wikilink image rendering in PDF exports
Summary
Fixes PDF exports rendering embedded wikilink images such as
![[image.png]]as raw text instead of images.Both desktop and web PDF export pipelines now preprocess wikilink image embeds into standard Markdown image syntax before passing the note to the existing preview renderer.
Changes
rewriteWikilinkImageEmbedspreprocessor in the desktop PDF export window.Examples
The PDF pipeline now converts wikilink image embeds such as:
into standard Markdown image nodes before rendering:
The existing asset resolver then maps each image target to the appropriate vault-relative asset URL. It supports note-relative paths, vault-root paths, and unique filename matches.
If an asset is missing, the export continues without throwing and retains the image's fallback alt text.
Testing
git diff --check: passedThe full parallel monorepo test run initially reported four unrelated load-sensitive failures, including two timeouts. All four passed when rerun together in isolation.