Skip to content

Homepage review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
izhamoidsin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Homepage review #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Chat/homepage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
<script>
function isNick() {
var str = document.getElementById("nick").value;
if (isEmpty(str)) alert = "���� ������";
if (isEmpty(str)) alert = "Ïîëå ïóñòîå";
else alert = "Blah-blah"
}
function isEmpty(str) {
return (str == null) || (str.length == 0);
}
</script>
<!--Move your JS to separate .js file and inlcude it into this project as external script-->
<link rel="stylesheet" href="Style.css" type"text/css">
<style>
@media screen {
Expand All @@ -21,13 +22,16 @@
}

</style>
<!--The same for CSS styles: use external file, include here as external stylseet-->
</head>
<body>
<h1 align="center" style="color:#000000" >CHATROOM by ZeddzZ version 0.1</h1>
<!--Do not specify style for DOM elements explicitly, use CSS for it-->
<button class="b3">Connect...</button>
<button class="b5">Settings</button>
<button class="b6">Help</button>
<button class="b7">About</button>
<!--Use more vrbose userfriendly names for custom classes, e.g. connect-btn, help-btn, etc.-->
<p>
<input type="text" class="i1" size="40" id="nick" placeholder="Nickname" >
<label for="text">
Expand All @@ -47,4 +51,4 @@ <h1 align="center" style="color:#000000" >CHATROOM by ZeddzZ version 0.1</h1>
</p>
</form>
</body>
</html>
</html>