General improvements - #92
Draft
charlesthobe wants to merge 15 commits into
Draft
Conversation
charlesthobe
marked this pull request as draft
March 24, 2026 22:21
charlesthobe
force-pushed
the
code_organization
branch
9 times, most recently
from
March 26, 2026 11:38
41efd43 to
9a12082
Compare
charlesthobe
marked this pull request as ready for review
March 26, 2026 11:39
charlesthobe
force-pushed
the
code_organization
branch
7 times, most recently
from
March 28, 2026 14:08
10047f1 to
85f57ef
Compare
charlesthobe
marked this pull request as draft
March 28, 2026 19:28
charlesthobe
force-pushed
the
code_organization
branch
6 times, most recently
from
March 31, 2026 13:52
f84f534 to
9bbfaa2
Compare
charlesthobe
marked this pull request as ready for review
March 31, 2026 13:59
charlesthobe
force-pushed
the
code_organization
branch
2 times, most recently
from
April 2, 2026 20:16
8d4c80d to
624e19f
Compare
charlesthobe
force-pushed
the
code_organization
branch
2 times, most recently
from
April 18, 2026 03:33
1378f67 to
9626715
Compare
charlesthobe
force-pushed
the
code_organization
branch
from
April 30, 2026 10:43
cfe2e93 to
6f9208b
Compare
charlesthobe
changed the title
charlesthobe
force-pushed
the
code_organization
branch
2 times, most recently
from
April 30, 2026 21:37
984547a to
4a695f3
Compare
charlesthobe
force-pushed
the
code_organization
branch
11 times, most recently
from
May 1, 2026 23:26
6a3ac79 to
ea8bd07
Compare
… struct and change the naming convention of its members to be more fitting
… next to data types
This also makes sure the constructor for "time_until_pulled_ev" is the correct value via promotion of the operands in the constructor because even in cases where all values of the operands were correct any intermediary result or the final result could overflow/underflow.
after an absurdly long time (weeks) of playback there was a possiblity that the PlayerThread could sleep for the same absurd amount of time, if queue_tick wraps around to 0 before pulled_event_tick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.