Skip to content

Added ignore/whitelist patterns for yamllint. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Added ignore/whitelist patterns for yamllint. #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5da583c
Added ignore/whitelist patterns for yamllint.
l-helmus-youwe Aug 13, 2024
5ae3a12
Change default value for ignore patterns
l-helmus-youwe Aug 13, 2024
6180205
Update changelog.
l-helmus-youwe Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 2.19
### Added
- Option to add/edit whitelist or ignore patterns to yamllint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was already possible with e.g this in your grumphp file

grumphp:
  tasks:
    yamllint:
      whitelist_patterns:
        - ^bamboo-specs\/(.*)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rutgerrademaker But do you want to have this exclude in every project setup?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the same as composer.strict:false :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only when bamboo yaml does not validate
In my case it failed on multi-docs (---) and includes (!)
Ideally I could just ignore those, but did not find a solution for that yet


## 2.18
### Added
- Grumphp will run the git hook in DDev (if available)
Expand Down
4 changes: 4 additions & 0 deletions config/default/grumphp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ parameters:
- /^pdepend.xml$/

yamllint.parse_constant: true
yamllint.whitelist_patterns: []
yamllint.ignore_patterns: []

phpcs.standard: ./phpcs.xml
phpcs.triggered_by: [php,phtml]
Expand Down Expand Up @@ -99,6 +101,8 @@ grumphp:

yamllint:
parse_constant: '%yamllint.parse_constant%'
whitelist_patterns: '%yamllint.whitelist_patterns%'
ignore_patterns: '%yamllint.ignore_patterns%'

phpcs:
standard: '%phpcs.standard%'
Expand Down