Skip to content
This repository was archived by the owner on Mar 3, 2024. It is now read-only.

Fixed possible bug and updated the README file - #6

Open
simmogs wants to merge 1 commit into
YouthTree:masterfrom
simmogs:master
Open

Fixed possible bug and updated the README file#6
simmogs wants to merge 1 commit into
YouthTree:masterfrom
simmogs:master

Conversation

@simmogs

@simmogs simmogs commented May 10, 2011

Copy link
Copy Markdown

Hi there,

This is my first pull request, so go easy on me!

  1. I think I spotted a bug in the initialization of Location, so I've updated the file.
  2. When I used the gem, I couldn't get any output with 'draw_map_of' but it did work with 'gmap'. I'm not sure which is right, but I've updated the docs to reflect the use of 'gmap', as that is the one that worked for me.

I tried to run the tests but failed with the following error;

RuntimeError: In order to use #url_for, you must include routing helpers explicitly. For instance, `include Rails.application.routes.url_helpers

I didn't want to mess with the code further as I suspect that one is probably me at fault. If you have any suggestions, I'd be glad to hear them.

Also, although I've got it working with a single address, I've failed to get any output passing multiple addresses. Again, any suggestions gratefully received.

Cheers,
Graeme

@simmogs

simmogs commented May 10, 2011

Copy link
Copy Markdown
Author

I fixed one of my own problems.

= gmap(@addresses_approved, :size => "640x600")

Multiples addresses work fine, but only if I specify a size for the container. Maybe the defaults aren't defaulting?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant